Skip to content

Confirmation email to citizen on form submission#936

Merged
jbarnsley10 merged 12 commits intomainfrom
feat/DF-330-citizen-email
Oct 9, 2025
Merged

Confirmation email to citizen on form submission#936
jbarnsley10 merged 12 commits intomainfrom
feat/DF-330-citizen-email

Conversation

@jbarnsley10
Copy link
Copy Markdown
Contributor

@jbarnsley10 jbarnsley10 commented Oct 7, 2025

Ticket DF-330

@jbarnsley10 jbarnsley10 marked this pull request as ready for review October 8, 2025 15:31
Comment thread src/server/index.test.ts
Comment thread src/server/plugins/SummaryPageWithConfirmationEmailController.ts
Comment thread src/server/plugins/SummaryPageWithConfirmationEmailController.ts
@whitewaterdesign
Copy link
Copy Markdown
Contributor

only issue is with the multiple type overrides, if possible would be good to resolve once plugin is merged

Copy link
Copy Markdown
Contributor

@whitewaterdesign whitewaterdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

Copy link
Copy Markdown
Contributor

@whitewaterdesign whitewaterdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/server/plugins/SummaryPageWithConfirmationEmailController.ts
Comment thread src/server/plugins/SummaryPageWithConfirmationEmailController.ts
Comment thread src/server/plugins/SummaryPageWithConfirmationEmailController.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 9, 2025

@jbarnsley10 jbarnsley10 merged commit 5353174 into main Oct 9, 2025
11 checks passed
@jbarnsley10 jbarnsley10 deleted the feat/DF-330-citizen-email branch October 9, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants